fix r & d not working from Metro sometimes
#47624
Closed
+11
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Changelog: [iOS][Fixed] - fix `r` & `d` not working from Metro sometimes While investigating these bugs, I've come across some cases where `r` (Reload) & `d` (Open Dev Menu) not working in Metro. * T206141946 / [WP: Reconnecting dev tools does not work after restarting the app](https://fb.workplace.com/groups/rn.debugger.feedback/posts/1107620434125533) * T206754760 / [WP: Can't launch DevTools from Metro sometimes](https://fb.workplace.com/groups/rn.debugger.feedback/posts/1112235073664069/) This is because when we 1. Start app without Metro 1. Start Metro 1. Reload from Dev Menu (rage shake) `RCTPackagerConnection` did not get notified about the change in bundle URL. It'd stay "listening" to the commands from the local bundle instead of Metro . Differential Revision: D65973309
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65973309 |
EdmondChuiHW
added a commit
to EdmondChuiHW/react-native
that referenced
this pull request
Nov 15, 2024
Summary: Changelog: [iOS][Fixed] - fix `r` & `d` not working from Metro sometimes While investigating these bugs, I've come across some cases where `r` (Reload) & `d` (Open Dev Menu) not working in Metro. * T206141946 / [WP: Reconnecting dev tools does not work after restarting the app](https://fb.workplace.com/groups/rn.debugger.feedback/posts/1107620434125533) * T206754760 / [WP: Can't launch DevTools from Metro sometimes](https://fb.workplace.com/groups/rn.debugger.feedback/posts/1112235073664069/) This is because when we 1. Start app without Metro 1. Start Metro 1. Reload from Dev Menu (rage shake) `RCTPackagerConnection` did not get notified about the change in bundle URL. It'd stay "listening" to the commands from the local bundle instead of Metro . Differential Revision: D65973309
|
This pull request has been merged in 9a60038. |
|
This pull request was successfully merged by @EdmondChuiHW in 9a60038 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[iOS][Fixed] - fix
r&dnot working from Metro sometimesWhile investigating these bugs, I've come across some cases where
r(Reload) &d(Open Dev Menu) not working in Metro.This is because when we
RCTPackagerConnectiondid not get notified about the change in bundle URL. It'd stay "listening" to the commands from the local bundle instead of Metro.
Differential Revision: D65973309